[Bug 72777] New: [Regression] MediaWiki should detect absent or outdated vendor

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Bug ID: 72777
Summary: [Regression] MediaWiki should detect absent or
outdated vendor
Product: MediaWiki
Version: 1.25-git
Hardware: All
OS: All
Status: NEW
Keywords: code-update-regression
Severity: blocker
Priority: Unprioritized
Component: General/Unknown
Assignee: wikibugs-***@lists.wikimedia.org
Reporter: ***@gmail.com
Web browser: ---
Mobile Platform: ---

Right now doing git-pull gives me an blank HTTP 500 response with no
information at all.

This is useless and unacceptable. Before the upcoming release, there must be a
detection of sorts. Similar to what we do when PHP version isn't supported or
when there are no skins installed, etc.

Going into the Apache error log gives me:

PHP Fatal error: Class 'Psr\\Log\\AbstractLogger' not found in
mediawiki/core/includes/debug/logger/legacy/Logger.php on line 40
PHP Stack trace:
PHP 1. {main}() mediawiki/core/index.php:0

Which isn't useful either.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Krinkle <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com
See Also| |https://bugzilla.wikimedia.
| |org/show_bug.cgi?id=72700

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #1 from Sam Reed (reedy) <***@reedyboy.net> ---
(In reply to Krinkle from comment #0)

Post by b***@wikimedia.org
Right now doing git-pull gives me an blank HTTP 500 response with no
information at all.

git pull where of what repo?

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Bryan Davis <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@wikimedia.org

--- Comment #2 from Bryan Davis <***@wikimedia.org> ---
The place where we do the php version check is before the autoloader, so that
won't work to fix the problem. Maybe we can put a check in the
includes/debug/logger/legacy/Logger.php file itself that is outside of the
class. That way when our autoloader first requires the file we could check to
see if the PSR-3 classes are loaded/loadable or not. I'm not exactly sure how
to trigger a better global warning however. I think about the best we could do
is make an error_log() call that gives a more explanatory message.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Bryan Davis <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|Unprioritized |High
Assignee|wikibugs-***@lists.wikimedia. |***@wikimedia.org
|org |

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #3 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 170274 had a related patch set uploaded by BryanDavis:
Throw exception when \Psr\Log\LoggerInterface is unavailable

https://gerrit.wikimedia.org/r/170274

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |PATCH_TO_REVIEW

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Sam Reed (reedy) <***@reedyboy.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@wikimedia.org

--- Comment #4 from Sam Reed (reedy) <***@reedyboy.net> ---
*** Bug 72932 has been marked as a duplicate of this bug. ***

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #5 from Ryan Kaldari <***@wikimedia.org> ---
I ran into the same problem. This should definitely generate some kind of
meaningful error message. Also someone should update the documentation on
mediawiki.org to explain that Composer is now required:
https://www.mediawiki.org/wiki/Download_from_Git#Prerequisites
I'll take a shot at it myself, but I can't guarantee it will be accurate.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Kunal Mehta (Legoktm) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #6 from Kunal Mehta (Legoktm) <***@gmail.com> ---
(In reply to Ryan Kaldari from comment #5)

Post by b***@wikimedia.org
I ran into the same problem. This should definitely generate some kind of
meaningful error message. Also someone should update the documentation on
https://www.mediawiki.org/wiki/Download_from_Git#Prerequisites
I'll take a shot at it myself, but I can't guarantee it will be accurate.

It was documented at
https://www.mediawiki.org/wiki/Download_from_Git#Fetch_external_libraries, but
I've stated in the Prerequisites that composer is recommended, but not
required.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #7 from Ryan Kaldari <***@wikimedia.org> ---
Legoktm: It seems to be required to me. If I don't install it, I just get a 500
server error (as Krinkle did).

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #8 from Sam Reed (reedy) <***@reedyboy.net> ---
You can just clone https://github.com/wikimedia/mediawiki-vendor instead. you
don't have to use composer

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #9 from Ryan Kaldari <***@wikimedia.org> ---
Ah, nevermind, I see now. You can install the vendor components manually if you
want to. That should be better explained in the prerequisites section.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #10 from Ryan Kaldari <***@wikimedia.org> ---
Guess I should read the entire instructions and not just the first part :)

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Ryan Kaldari <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|--- |FIXED

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #11 from Ryan Kaldari <***@wikimedia.org> ---
Fixed in https://gerrit.wikimedia.org/r/#/c/170274/

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #12 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 170274 merged by jenkins-bot:
die() with explanation when \Psr\Log\LoggerInterface is missing

https://gerrit.wikimedia.org/r/170274

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Bryan Davis <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---

--- Comment #13 from Bryan Davis <***@wikimedia.org> ---
We need a more general solution for this problem than the one off fix for PSR-3
that was applied.

I'm thinking that we could install an autolaoder via spl_autoload_register()
*after* all other autoloaders to give a nice warning when a class has not been
found yet.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

--- Comment #14 from Bryan Davis <***@wikimedia.org> ---
I think we could also create a git hook that would compare composer.json and
composer.lock when composer.json is seen to be updated by a pull and give the
user a warning and instructions on how to proceed. The git install instructions
could include details on how to install this hook and MediaWiki-Vagrant could
do it automatically.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=72777

Bryan Davis <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|High |Normal
Severity|blocker |major