[Bug 73585] New: MobileFrontend no longer invokes wikitext editor properly or changes editor, different behavior in Chrome and Firefox

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

Bug ID: 73585
Summary: MobileFrontend no longer invokes wikitext editor
properly or changes editor, different behavior in
Chrome and Firefox
Product: MobileFrontend
Version: unspecified
Hardware: All
OS: All
Status: NEW
Keywords: browser-test-bug
Severity: major
Priority: Unprioritized
Component: stable
Assignee: wikibugs-***@lists.wikimedia.org
Reporter: ***@wikimedia.org
CC: ***@wikimedia.org, ***@wikimedia.org,
***@wikimedia.org, ***@gmail.com,
***@wikimedia.org, ***@wikimedia.org
Web browser: ---
Mobile Platform: ---

Created attachment 17164
--> https://bugzilla.wikimedia.org/attachment.cgi?id=17164&action=edit
switch edit mode fails in Chrome

This manifests in several ways, see the browser test failures at
Chrome:
https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/
Firefox:
https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/

The common case for Chrome and Firefox:

As a logged-in user with access to VisualEditor, edit any page.
Attempt to switch from the wikitext editor to VE using the dropdown controls.
Nothing happens, VE does not show up. See screen shot.

The Firefox-only issue:

Attempt to edit a new page by supplying a bogus URL, e.g.
http://en.m.wikipedia.beta.wmflabs.org/wiki/Foobarbaz

Clicking the edit icon does nothing.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #1 from Bingle <bingle-***@wikimedia.org> ---
Prioritization and scheduling of this bug is tracked on Trello card
https://trello.com/c/LKgERdDV

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

Florian <***@t-online.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@t-on
| |line.de

--- Comment #2 from Florian <***@t-online.de> ---
For the second (FF only):
[10:11:21.144] "[Exception... "Failure" nsresult: "0x80004005
(NS_ERROR_FAILURE)" location: "JS frame ::
http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141030T090804Z
:: EditorOverlay<._loadContent/< :: line 17" data: no]" [object
XPCWrappedNative_NoHelper]

Caused by: I2a3eab234338bae6258abcde99144bdd2464805f

VE: confirmed :/

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #3 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174384 had a related patch set uploaded by Florianschmidtwelzow:
Don't try to set cursor on hidden elements

https://gerrit.wikimedia.org/r/174384

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |PATCH_TO_REVIEW

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

Jon <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|MobileFrontend no longer |Cannot create a new page in
|invokes wikitext editor |Firefox. Edit button
|properly or changes editor, |doesn't respond
|different behavior in |
|Chrome and Firefox |

--- Comment #4 from Jon <***@wikimedia.org> ---
This seems to be specific for new pages in Firefox.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #5 from Rummana Yasmeen <***@wikimedia.org> ---
Nope, this is not a browser/page specific issue,was happening for me in all
pages even in iOS safari.Once you switch to edit source mode the "Edit" button
will no longer work from that point on.And then for a new page, it always opens
the Edit Source mode first, so thats why its always reproducible for a new page
too.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #6 from Florian <***@t-online.de> ---
Jon is talking about the Firefox only problem :) The VE problem is right, it
doesn't work on all pages :(

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #7 from Rummana Yasmeen <***@wikimedia.org> ---
Ah got it, so this patch is going to fix for all pages in all browsers?

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #8 from Florian <***@t-online.de> ---
Unhappily no, this patch adresses the Firefox problem. For now, I haven't had
the time to look into it, why VE doesn't work :/

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

Rummana Yasmeen <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Cannot create a new page in |[Regression wmf9]Cannot
|Firefox. Edit button |create a new page in
|doesn't respond |Firefox. Edit button
| |doesn't respond

--- Comment #9 from Rummana Yasmeen <***@wikimedia.org> ---
okay,just to keep note, this bug is now in test2 as well after today's
deployment since it was regression from wmf9.I will test the fix in test2 once
it is merged and backported.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #10 from Jon <***@wikimedia.org> ---
If there are two problems here there should be 2 bugs..

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #11 from Jon <***@wikimedia.org> ---
I captured the other issue in bug 73646

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73585

--- Comment #12 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174384 abandoned by Florianschmidtwelzow:
Don't try to set cursor on hidden elements

Reason:
Function reverted in: I672d04c16f9348f7e08c4f64b339b307276d2a5a

https://gerrit.wikimedia.org/r/174384