[Bug 73587] New: Active neutral buttons are ugly - yellow text on grey background

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

Bug ID: 73587
Summary: Active neutral buttons are ugly - yellow text on grey
background
Product: MediaWiki
Version: 1.25-git
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: MediaWiki UI
Assignee: wikibugs-***@lists.wikimedia.org
Reporter: ***@wikimedia.org
CC: ***@wikimedia.org, ***@wikimedia.org,
***@wikimedia.org, ***@wikimedia.org,
***@wikimedia.org, ***@wikimedia.org
Web browser: ---
Mobile Platform: ---

Created attachment 17167
--> https://bugzilla.wikimedia.org/attachment.cgi?id=17167&action=edit
screenshot

See the screenshot (taken at https://en.m.wikipedia.org/wiki/Ezra_Meeker)

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

Matthew Flaschen <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|***@wikimedia.org |

--- Comment #1 from Matthew Flaschen <***@wikimedia.org> ---
Note, this is inheriting from a general a:active rule, so that will have to be
overridden.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

Matthew Flaschen <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Active neutral buttons are |Active neutral <a> element
|ugly - yellow text on grey |buttons are ugly - yellow
|background |text on grey background

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

--- Comment #2 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174383 had a related patch set uploaded by Prtksxna:
mediawiki.ui: button: Add specific hover and active rule for color

https://gerrit.wikimedia.org/r/174383

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |PATCH_TO_REVIEW

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

--- Comment #3 from Prateek Saxena <***@wikimedia.org> ---
Would it be better if the the element used <button> instead of <a>?

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

Prateek Saxena <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|--- |FIXED

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73587

--- Comment #4 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174383 merged by jenkins-bot:
mediawiki.ui: button: Add specific hover and active rule for color

https://gerrit.wikimedia.org/r/174383