Discussion:
[Bug 61927] New: Flow: Sends malformed RC events
b***@wikimedia.org
2014-02-25 20:25:28 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

Bug ID: 61927
Summary: Flow: Sends malformed RC events
Product: MediaWiki extensions
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Flow
Assignee: wikibugs-***@lists.wikimedia.org
Reporter: ***@gmail.com
CC: ***@wikimedia.org, ***@wikimedia.org,
***@gmail.com, ***@wikimedia.org
Web browser: ---
Mobile Platform: ---

Activity (such as replies) in Flow currently result in the following RC entry:


irc.wikimedia.org/#test2.wikipedia

rc-pmtpa: [[Talk:Flow QA]] !
http://test2.wikipedia.org/w/index.php?diff=0&oldid=0&rcid=82816 * Krinkle *
(+31) reply,rpw4ywdy0xw7t5ou,rpwgr7r79uy8pznh

chat.freenode.net/#cvn-sw

[[m:CVNBot]]: IP [[test2wiki:User:162.222.73.148]] matched edit summary
"[bcdfghjklmnpqrstvwxz]{8,}" (possible nonsense) [[test2wiki:Talk:Flow QA]]
(+22) Diff: https://test2.wikipedia.org/?diff=0&oldid=0&rcid=82813
"reply,rpwgkgfa3bbexlwf,rpwgkgfd7m5qq1b3"


It is paramount that Flow generates more sensible RC events before being
enabled in a visible way, to avoid:

1) Unusable clutter for vandalism patrollers (they are overwhelmed as it is
already in our crippled system).



-- and, though less important for the short term: --

2) Spam evading our patrollers.

#1 Would be solved by having these not be useless (either don't emit rc events
for now, or implement them in a way that produces a useful link and doesn't
abuse the edit summary field).

#2 Would be solved by making the content actions (creation and modification of
posts) patrollable by:
* - Defaulting to rc_patrolled=0
* - Exposing the [mark as patrolled] link somewhere in the UI
or; by continuing to keep them outside rcpatrol and instead provide a different
means for patrollers to monitor Flow events on wikis with $wgUseRCPatrol
enabled. Though I'd recommend against that as that will likely not take off and
not integrate with any of the dozens of patrol workflows, and considering the
patrol workforce isn't huge, giving them yet another thing to monitor is
probably not productive, and would also cost more work by the Flow team to
invent. So best to simply defer to the system core already has available. It's
a very minimal system (simple boolean flag and log event), but you'd be
surprised how much unofficial infrastructure is built atop that.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-02-25 20:25:45 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

Krinkle <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Flow: Sends malformed RC |Flow: Don't polute rc
|events |stream with malformed RC
| |events
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-02-25 20:26:03 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

Krinkle <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|Unprioritized |High
CC| |***@gmail.com
Severity|normal |critical
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-02-25 21:12:02 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

Kunal Mehta (Legoktm) <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |***@gmail.com
Resolution|--- |DUPLICATE

--- Comment #1 from Kunal Mehta (Legoktm) <***@gmail.com> ---


*** This bug has been marked as a duplicate of bug 60559 ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-03-06 19:04:22 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

--- Comment #2 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 117246 had a related patch set uploaded by EBernhardson:
New hook CheckUserInsertForRecentChange

https://gerrit.wikimedia.org/r/117246
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-03-06 19:04:25 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |PATCH_TO_REVIEW
Resolution|DUPLICATE |---
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-03-06 19:28:31 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

--- Comment #3 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 117246 merged by jenkins-bot:
New hook CheckUserInsertForRecentChange

https://gerrit.wikimedia.org/r/117246
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-03-06 19:42:43 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

--- Comment #4 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 117253 had a related patch set uploaded by EBernhardson:
Inject CheckUser data more directly

https://gerrit.wikimedia.org/r/117253
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-03-21 20:30:02 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

Quiddity <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---

--- Comment #7 from Quiddity <***@gmail.com> ---
(In reply to Maryana Pinchuk from comment #6)
This should be fixed - Krinkle or Lego, can you test to make sure? It
appears the RC feed is an invite-only channel :)
The RC feed is on a different IRC network (not freenode):
irc://irc.wikimedia.org:6667/mediawiki.wikipedia (other currently relevant
channels: #meta.wikimedia and #en.wikipedia )
--

I'm reopening this bug, because the current situation doesn't address Krinkle's
concern #2 at all, and concern #1 still needs a working link. (Once the link
works properly, this bug should probably be closed, and a new (less urgent) one
created for concern #2 (integration with patrol workflows)

--
Detailed note:

I see this in today's #mediawiki.wikipedia feed:

broken (completely wrong page) diff link:
<rc-pmtpa> [[Talk:Beta Features/Hovercards]] !
http://www.mediawiki.org/w/index.php?diff=0&oldid=0&rcid=1060297 * TheDJ *
(+1430)

(That should instead link to the actual:
https://www.mediawiki.org/w/index.php?title=Talk:Beta_Features/Hovercards&topic_postId=rrdvkg8xh26l1z94&workflow=rrc19ij5nimkme01#flow-post-rrdvkg8xh26l1z94


Comparison item (a normal page edit):
<rc-pmtpa> [[Google Summer of Code 2014]]
http://www.mediawiki.org/w/index.php?diff=936244&oldid=936243&rcid=1060272 *
Qgil * (-619) Removing previous list of students interested
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-03-24 21:45:01 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

--- Comment #8 from Erik Bernhardson <***@wikimedia.org> ---
API XML feed output :

http://test2.wikipedia.org/w/api.php?format=jsonfm&action=query&list=recentchanges
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
b***@wikimedia.org
2014-11-21 00:11:06 UTC
Permalink
https://bugzilla.wikimedia.org/show_bug.cgi?id=61927

--- Comment #9 from Krinkle <***@gmail.com> ---
The broken links are gone, but still is useless from the perspective of
patrolling recent changes:

rc-pmtpa: [[Topic:S6hfg9fw4mka4cbb]] !
http://www.mediawiki.org/w/index.php?title=Topic:S6hfg9fw4mka4cbb&action=history
* Krinkle * (+13) Krinkle commented on "Another new topic" (Another reply)

At some point in the past it linked to the topic page. That wasn't super useful
as one had to find the right reply, but at least the relevant content was
displayed at the provided link. And in most cases there would only be one post
(creation of topic) or the first reply.

But now it doesn't do that anymore. Instead it now links to the history page
which doesn't display the change made nor the topic changed. Instead it links
to where the real recent changes are (action=history) and among other entries,
one can find the right one:

* (cur prev) topic 23:48, 20 November 2014 . . Krinkle (talk | contribs |
block) commented[1] on "Another new topic" (Reply) . . (+45)‎ (hide)
[1]
https://www.mediawiki.org/w/index.php?title=Topic:S6hfg9fw4mka4cbb&topic_showPostId=s6ht1f60bzxe1erp#flow-post-s6ht1f60bzxe1erp

That's basically the line that should be in the RC event. Especially the url
behind "commented" would be expected to be in there.
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
Loading...