[Bug 73677] New: OOUI: Get rid of inline styles in LabelElement

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73677

Bug ID: 73677
Summary: OOUI: Get rid of inline styles in LabelElement
Product: OOjs UI
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Technical Debt
Assignee: jforrester+***@wikimedia.org
Reporter: ***@gmail.com
CC: ***@wikimedia.org, ***@gmail.com
Web browser: ---
Mobile Platform: ---

We should get rid of inline styles in LabelElement.

this.$label.css( 'display', !label ? 'none' : '' );

$this->target->setAttributes( !$label ? array( 'style' => 'display: none;' ) :
array() );

I think this is dumb, it should be done by removing oo-ui-labeledElement
the same way we do with icons and indicators - and in all 3 cases this
should be done at a higher and more general level. Nonetheless, the
point is if you make the label empty empty empty (see first case from
above) we want to avoid styles being applied to it (probably?).
I'm less sure about this case, as you can see, but for compatibility
don't want to change it until we have a cohesive plan.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73677

Bartosz Dziewoński <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #1 from Bartosz Dziewoński <***@gmail.com> ---
(In reply to Bartosz Dziewoński from comment #0)

I think this is dumb, it should be done by removing oo-ui-labeledElement
the same way we do with icons and indicators

So, the fun part is, we already do that. So maybe we can just kill the junk and
tweak some CSS and that's it.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73677

James Forrester <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Priority|Unprioritized |Normal
Status|NEW |ASSIGNED
Summary|OOUI: Get rid of inline |OOjs UI: Get rid of inline
|styles in LabelElement |styles in LabelElement
Severity|normal |enhancement

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73677

--- Comment #2 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174844 had a related patch set uploaded by Bartosz Dziewoński:
LabelElement: Kill inline styles

https://gerrit.wikimedia.org/r/174844

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73677

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |PATCH_TO_REVIEW