[Bug 73633] New: WikiGrok broken in beta - JS error

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

Bug ID: 73633
Summary: WikiGrok broken in beta - JS error
Product: MobileFrontend
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: beta
Assignee: wikibugs-***@lists.wikimedia.org
Reporter: ***@wikimedia.org
CC: ***@wikimedia.org, ***@wikimedia.org,
***@wikimedia.org, ***@gmail.com,
***@wikimedia.org
Web browser: ---
Mobile Platform: ---

If you try to load WikiGrok on Beta Labs, it doesn't load and a Javascript
error is thrown: Attempt to run module outside declared environment mode beta

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #1 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174616 had a related patch set uploaded by Kaldari:
Disabling mobile infobox experiment for now - throwing JS error

https://gerrit.wikimedia.org/r/174616

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |PATCH_TO_REVIEW

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #2 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174616 merged by jenkins-bot:
Disabling mobile infobox experiment for now - throwing JS error

https://gerrit.wikimedia.org/r/174616

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #3 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174620 had a related patch set uploaded by Kaldari:
Disabling mobile infobox experiment for now - throwing JS error

https://gerrit.wikimedia.org/r/174620

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #4 from Jon <***@wikimedia.org> ---
can you elaborate. infobox should only be loading in alpha. of it's leaking to
beta something is seriously wrong.

PS. please please please can we not self merge. I keep telling you this. It's
not hard to get someone to +2 in our team size and I suspect you have
misunderstood the problem here.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #5 from Ryan Kaldari <***@wikimedia.org> ---
Jon: I didn't self merge. Max merged it. Also I'm not sure what you mean about
misunderstanding the problem. I haven't claimed to understand the problem at
all. I just disabled it for the time being. I didn't try to fix anything (other
than to stop the JS error).

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #6 from Ryan Kaldari <***@wikimedia.org> ---
I think I found the problem: mobile.wikigrok.dialog has mobile.alpha listed as
a dependency, thus it's going to try to run anything in mobile.alpha when
wikigrok loads in beta. I'll fix it up and turn the infoboxes back on.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #7 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174620 abandoned by Kaldari:
Disabling mobile infobox experiment for now - throwing JS error

Reason:
Found the root cause...

https://gerrit.wikimedia.org/r/174620

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #8 from Jon <***@wikimedia.org> ---
That sounds right :) I'm here to +2 the patch...

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #9 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174631 had a related patch set uploaded by Kaldari:
Fixing dependency for mobile.wikigrok.dialog

https://gerrit.wikimedia.org/r/174631

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #10 from Ryan Kaldari <***@wikimedia.org> ---
Patch submitted and waiting for +2 :)

If you're wondering why I turned infoboxes off without troubleshooting it
further, it's because Maryana told me it was broken right as I was about to
leave work, so I just traced the error and did a temporary fix (which would
have been easier with a feature flag).

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #11 from Jon <***@wikimedia.org> ---
Needs work. Am on irc if you need to chat on can fix up myself.

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #12 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174631 merged by jenkins-bot:
Fixing dependency for mobile.wikigrok.dialog

https://gerrit.wikimedia.org/r/174631

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

Jon <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|--- |FIXED

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #13 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174749 had a related patch set uploaded by Kaldari:
Fixing dependency for mobile.wikigrok.dialog

https://gerrit.wikimedia.org/r/174749

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

Gerrit Notification Bot <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |PATCH_TO_REVIEW
Resolution|FIXED |---

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

Ryan Kaldari <***@wikimedia.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|PATCH_TO_REVIEW |RESOLVED
Resolution|--- |FIXED

[b***@wikimedia.org]

https://bugzilla.wikimedia.org/show_bug.cgi?id=73633

--- Comment #14 from Gerrit Notification Bot <***@wikimedia.org> ---
Change 174749 merged by MaxSem:
Fixing dependency for mobile.wikigrok.dialog

https://gerrit.wikimedia.org/r/174749